New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: tweaks + bugfixes #2042

Merged
merged 7 commits into from Dec 21, 2017

Conversation

2 participants
@brauner
Member

brauner commented Dec 15, 2017

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

@brauner brauner changed the title from start: set handler state to STOPPED to start: tweaks + bugfixes Dec 15, 2017

@brauner brauner added Incomplete and removed Incomplete labels Dec 15, 2017

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 16, 2017

Member

Errors are now unrelated to the patches.

Member

brauner commented Dec 16, 2017

Errors are now unrelated to the patches.

@brauner brauner requested a review from hallyn Dec 16, 2017

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 16, 2017

Member

This should get priority over the other ones. :)

Member

brauner commented Dec 16, 2017

This should get priority over the other ones. :)

brauner added some commits Dec 15, 2017

tests: expand lxc_raw_clone() tests
- test CLONE_VFORK
- test CLONE_FILES

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
namespace: add lxc_raw_getpid()
Because of older glibc's pid cache (up to 2.25) whenever clone() is called the
child must must retrieve it's own pid via lxc_raw_getpid().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
tree-wide: s/getpid()/lxc_raw_getpid()/g
This is to avoid bad surprises caused by older glibc's pid cache (up to 2.25)
when using clone().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
namespace: comment lxc_{raw_}clone()
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
namespace: add lxc_raw_clone_cb()
This is a copy-on-write (no stack passed) variant of lxc_clone().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
start: use lxc_raw_clone_cb() where possible
This way we can rely on the kernel's copy-on-write support similar to fork().

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
start: log closing cmd socket and STOPPED state
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

@hallyn hallyn merged commit 1509013 into lxc:master Dec 21, 2017

3 of 4 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment