New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxccontainer: revert set_running_config_item() #2065

Merged
merged 1 commit into from Jan 3, 2018

Conversation

2 participants
@brauner
Member

brauner commented Jan 1, 2018

  • As discussed we will have a proper API extension that will allow updating
    various parts of a running container. The prior approach wasn't a good idea.

  • Revert this is not a problem since we haven't released any version with the
    set_running_config_item() API extension.

  • I'm not simply reverting so that master users can still call into new
    liblxc's without crashing the container. This is achieved by keeping the
    commands callback struct member number identical.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

lxccontainer: revert set_running_config_item()
- As discussed we will have a proper API extension that will allow updating
  various parts of a running container. The prior approach wasn't a good idea.

- Revert this is not a problem since we haven't released any version with the
  set_running_config_item() API extension.

- I'm not simply reverting so that master users can still call into new
  liblxc's without crashing the container. This is achieved by keeping the
  commands callback struct member number identical.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

@brauner brauner requested a review from stgraber Jan 1, 2018

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 1, 2018

Member

@stgraber, this should be a fairly uncontroversial merge. :)

Member

brauner commented Jan 1, 2018

@stgraber, this should be a fairly uncontroversial merge. :)

@stgraber stgraber merged commit acd546a into lxc:master Jan 3, 2018

3 of 4 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment