New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configurations without root mapping #2066

Merged
merged 5 commits into from Jan 3, 2018

Conversation

3 participants
@brauner
Member

brauner commented Jan 2, 2018

Closes #2033.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

brauner added some commits Jan 2, 2018

conf: adapt idmap helpers
- mapped_hostid_entry()
- idmap_add()

Closes #2033.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
conf: adapt userns_exec_1()
Closes #2033.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
conf{ile}: detect ns{g,u}id mapping for root
Closes #2033.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
cgfsng: use init {g,u}id
If no id mapping for the container's root id is defined try to us the id
mappings specified via lxc.init.{g,u}id.

Closes #2033.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
conf: detect if devpts can be mounted with gid=5
Closes #2033.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

@brauner brauner requested a review from hallyn Jan 2, 2018

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 2, 2018

Member

@flx42, does that cover your use-case?

Member

brauner commented Jan 2, 2018

@flx42, does that cover your use-case?

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Jan 2, 2018

Contributor

@brauner I'll test this patch set ASAP, thanks!

Contributor

flx42 commented Jan 2, 2018

@brauner I'll test this patch set ASAP, thanks!

@flx42

This comment has been minimized.

Show comment
Hide comment
@flx42

flx42 Jan 3, 2018

Contributor

It will still require a root mapping for lxc-create, right?
May I ask which configuration you used for the container? I was not able to make it work, will dig more into it tomorrow.

Contributor

flx42 commented Jan 3, 2018

It will still require a root mapping for lxc-create, right?
May I ask which configuration you used for the container? I was not able to make it work, will dig more into it tomorrow.

@hallyn hallyn merged commit fd7374d into lxc:master Jan 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 3, 2018

Member
Member

brauner commented Jan 3, 2018

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 3, 2018

Member

@flx42, here's a POC:
asciicast

Member

brauner commented Jan 3, 2018

@flx42, here's a POC:
asciicast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment