New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return check for 'lxc_cmd_get_name' #2077

Merged
merged 1 commit into from Jan 8, 2018

Conversation

3 participants
@lifeng68
Contributor

lifeng68 commented Jan 8, 2018

If 'lxc_cmd_get_name' failed and return with NULL, this will cause a segment fault when calling ‘add_to_array’.

Signed-off-by: LiFeng lifeng68@huawei.com

@lxc-jenkins

This comment has been minimized.

Show comment
Hide comment
@lxc-jenkins

lxc-jenkins Jan 8, 2018

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

lxc-jenkins commented Jan 8, 2018

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 8, 2018

Member

jenkins: test this please

Member

brauner commented Jan 8, 2018

jenkins: test this please

@brauner brauner merged commit 9531b90 into lxc:master Jan 8, 2018

4 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 8, 2018

Member

Thanks!

Member

brauner commented Jan 8, 2018

Thanks!

Add return check for 'lxc_cmd_get_name'
If 'lxc_cmd_get_name' failed and return with NULL, this would cause a segment fault.

Signed-off-by: LiFeng <lifeng68@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment