Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix usage of boolean function set_config_item #2214

Merged
merged 1 commit into from Mar 14, 2018

Conversation

3 participants
@flx42
Copy link
Contributor

commented Mar 14, 2018

Signed-off-by: Felix Abecassis fabecassis@nvidia.com

The command lxc-execute --define lxc.environment='foo=bar' -n ubuntu -- was failing silently, with exit return code 1.

git bisect:

791e7a73a9bca8dbde19afb49f172a901ce0dd43 is the first bad commit
commit 791e7a73a9bca8dbde19afb49f172a901ce0dd43
Author: Christian Brauner <christian.brauner@ubuntu.com>
Date:   Fri Jan 12 15:31:03 2018 +0100

    tools: move lxc-execute to API symbols only
    
    Closes #2073.
    
    Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
tools: fix usage of boolean function set_config_item
Signed-off-by: Felix Abecassis <fabecassis@nvidia.com>
@lxc-jenkins

This comment has been minimized.

Copy link

commented Mar 14, 2018

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner brauner merged commit 0b62809 into lxc:master Mar 14, 2018

3 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@flx42

This comment has been minimized.

Copy link
Contributor Author

commented Mar 14, 2018

thanks @brauner !

@brauner

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

@flx42, thanks for the patch! :)

@flx42 flx42 deleted the flx42:fix-lxc-execute branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.