New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ifup/down and remove usless parameter passing #2229

Merged
merged 1 commit into from Mar 22, 2018

Conversation

3 participants
@fliiiix
Contributor

fliiiix commented Mar 22, 2018

Naming functions like tools but do something different is not that intuitive https://manpages.debian.org/testing/ifupdown/ifup.8.en.html

That is why I changed it to _ifup and _ifdown to make that clear that it does something different.

Also there is no need to pass along environment parameters as function parameter.

Signed-off-by: Felix hi@l33t.name

@lxc-jenkins

This comment has been minimized.

lxc-jenkins commented Mar 22, 2018

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner brauner requested a review from stgraber Mar 22, 2018

Rename ifup/down and remove usless parameter passing
Signed-off-by: Felix <de-ch@hotmail.de>

@stgraber stgraber merged commit 1b849a8 into lxc:master Mar 22, 2018

3 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment