Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conf: simplify autodev #2235

Merged
merged 1 commit into from Mar 26, 2018

Conversation

@brauner
Copy link
Member

commented Mar 25, 2018

This function was way more syscall heavy than it needed to be.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

@brauner brauner force-pushed the brauner:2018-03-25/simplify_autodev branch from d1bd27e to 71fc709 Mar 25, 2018

@@ -1235,7 +1235,7 @@ static int lxc_fill_autodev(const struct lxc_rootfs *rootfs)
if (!dir_exists(path))
return 0;

INFO("Populating \"/dev\"");
INFO("Populating devtmpfs");

This comment has been minimized.

Copy link
@stgraber

stgraber Mar 25, 2018

Member

It's specifically NOT a devtmpfs though, right?

This comment has been minimized.

Copy link
@brauner

brauner Mar 25, 2018

Author Member

Technically it's a tmpfs, yes. I just thought that devtmpfs is nicer. But I can update or you can merge now and I'll send a small update later

@brauner brauner force-pushed the brauner:2018-03-25/simplify_autodev branch from 71fc709 to 5084327 Mar 25, 2018

@brauner

This comment has been minimized.

Copy link
Member Author

commented Mar 25, 2018

@stgraber, updated.

@brauner brauner force-pushed the brauner:2018-03-25/simplify_autodev branch from 5084327 to 7c7a1ee Mar 26, 2018

conf: simplify lxc_fill_autodev()
This function was way more syscall heavy than it needed to be.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

@brauner brauner force-pushed the brauner:2018-03-25/simplify_autodev branch from 7c7a1ee to 5e73416 Mar 26, 2018

@stgraber stgraber merged commit 065d5d0 into lxc:master Mar 26, 2018

4 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.