New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log: change LOG macros using strerror to SYS* macros #2431
Conversation
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
…acro Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes needed afaict. Only one nit. But that's not blocking the merge.
return -1; | ||
} | ||
|
||
if (!ret) | ||
return 0; | ||
|
||
if ((size_t)ret != sizeof(sync)) { | ||
ERROR("unexpected sync size: %zu expected %zu", (size_t)ret, sizeof(sync)); | ||
ERROR("Unexpected sync size: %zu expected %zu", (size_t)ret, sizeof(sync)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
@@ -60,7 +60,7 @@ static int __sync_wait(int fd, int sequence) | |||
} | |||
|
|||
if (sync != sequence) { | |||
ERROR("invalid sequence number %d. expected %d", | |||
ERROR("Invalid sequence number %d. expected %d", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost, should be Invalid sequence number %d. Expected sequence number %d
.
jenkins: test this please |
Thanks!! |
Hello,
LOG macros using strerror are changed to SYS* macros.
Thanks.