Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log: change LOG macros using strerror to SYS* macros #2431

Merged
merged 4 commits into from Jun 26, 2018
Merged

log: change LOG macros using strerror to SYS* macros #2431

merged 4 commits into from Jun 26, 2018

Conversation

2xsec
Copy link
Contributor

@2xsec 2xsec commented Jun 26, 2018

Hello,

LOG macros using strerror are changed to SYS* macros.

Thanks.

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
…acro

Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
Signed-off-by: 2xsec <dh48.jeong@samsung.com>
@lxc-jenkins
Copy link

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

Copy link
Member

@brauner brauner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes needed afaict. Only one nit. But that's not blocking the merge.

return -1;
}

if (!ret)
return 0;

if ((size_t)ret != sizeof(sync)) {
ERROR("unexpected sync size: %zu expected %zu", (size_t)ret, sizeof(sync));
ERROR("Unexpected sync size: %zu expected %zu", (size_t)ret, sizeof(sync));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@@ -60,7 +60,7 @@ static int __sync_wait(int fd, int sequence)
}

if (sync != sequence) {
ERROR("invalid sequence number %d. expected %d",
ERROR("Invalid sequence number %d. expected %d",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, should be Invalid sequence number %d. Expected sequence number %d.

@brauner
Copy link
Member

brauner commented Jun 26, 2018

jenkins: test this please

@brauner brauner merged commit 508f470 into lxc:master Jun 26, 2018
@brauner
Copy link
Member

brauner commented Jun 26, 2018

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants