Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoconf 2.69 conformance #3146

Merged
merged 2 commits into from Oct 1, 2019

Conversation

@caioboffo
Copy link
Contributor

commented Sep 30, 2019

This PR adds to configure.ac the AC_PREREQ(2.69) to ensure that a recent enough version of Autoconf is being used. It also changes AC_HELP_STRING renamed to AS_HELP_STRING in Autoconf 2.69 and allows users to give to ./configure the option '--enable-feature' or '--with-package' by setting the action-if-given values. I'd like to send more patches to configure.ac but will open small PR to easy the review process. Please let me know if there is something else that you guys would like to do in configure.ac.

…HELP_STRING for AS_HELP_STRING

Signed-off-by: Caio B. Silva <caioboffo@gmail.com>
@lxc-jenkins

This comment has been minimized.

Copy link

commented Sep 30, 2019

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

…e, if an option is given run shell commands action-if-given

Signed-off-by: Caio B. Silva <caioboffo@gmail.com>
@caioboffo caioboffo force-pushed the caioboffo:autoconf_2_69_conformance branch from 60ec5ab to b2963bf Sep 30, 2019
@brauner

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

jenkins: test this please

@lxc-jenkins

This comment has been minimized.

Copy link

commented Oct 1, 2019

Testsuite passed

@brauner

This comment has been minimized.

Copy link
Member

commented Oct 1, 2019

Tanks!

@brauner brauner merged commit 8d06d0c into lxc:master Oct 1, 2019
4 checks passed
4 checks passed
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
Testsuite Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@caioboffo

This comment has been minimized.

Copy link
Contributor Author

commented Oct 1, 2019

I'm glad to help!

@caioboffo caioboffo deleted the caioboffo:autoconf_2_69_conformance branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.