Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lxc-update-config in network.address #3149

Merged
merged 1 commit into from Oct 3, 2019

Conversation

@AlbanVidal
Copy link

commented Oct 3, 2019

Dear developpers,

When we use lxc-update-config to translate a LXCv2 to LXCv3 configuration file, we have a issue with the parameters lxc.network.X.ipv4.address.

The output of the translate is:
lxc.net.0.ipv4.address.address

Instead of:
lxc.net.0.ipv4.address

This introduce a bug: the container want to use the gateway address as a secondary network address.

Regards,

Signed-off-by: Alban VIDAL zordhak@debian.org

Alban VIDAL
Signed-off-by: Alban VIDAL <zordhak@debian.org>
@lxc-jenkins

This comment has been minimized.

Copy link

commented Oct 3, 2019

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Thanks! :)

@brauner brauner merged commit 39eaee5 into lxc:master Oct 3, 2019
3 checks passed
3 checks passed
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.