Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add tests making sure the exit code is appropriate. #3175

Merged
merged 1 commit into from Oct 30, 2019

Conversation

@ralt
Copy link
Contributor

ralt commented Oct 29, 2019

lxc2 broke this feature for lxc-execute, and lxc3 broke it for
lxc-attach. This adds a test making sure we don't do the same mistake
a third time.

@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Oct 29, 2019

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@ralt ralt force-pushed the ralt:pr/execute-attach-exit-code-tests branch 3 times, most recently from 380ca56 to f97e600 Oct 29, 2019
src/tests/Makefile.am Outdated Show resolved Hide resolved
lxc2 broke this feature for lxc-execute, and lxc3 broke it for
lxc-attach. This adds a test making sure we don't do the same mistake
a third time.

Signed-off-by: Florian Margaine <florian@platform.sh>
@ralt ralt force-pushed the ralt:pr/execute-attach-exit-code-tests branch from f97e600 to 188f883 Oct 29, 2019
@brauner

This comment has been minimized.

Copy link
Member

brauner commented Oct 30, 2019

jenkins: test this please

@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Oct 30, 2019

Testsuite passed

@brauner brauner merged commit f09700d into lxc:master Oct 30, 2019
4 checks passed
4 checks passed
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
Testsuite Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brauner

This comment has been minimized.

Copy link
Member

brauner commented Oct 30, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.