Add support for using lvm thin provisioning #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, The change looks reasonable but the diff is a bit messy. Would you mind updating your branch, squashing to a single commit, adding Signed-off-by and dropping any unneeded delta (whitespaces/tabs are poluting the diff currently). Thanks |
ghost
assigned 
hallyn
added a commit
to hallyn/lxc
that referenced
this pull request
Nov 12, 2014
Add initial rest-api spec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #32, add support for specifying a thin pool at lxc-create time.
Still needs some work to expose the thin pool defaults through lxc config.