New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for using lvm thin provisioning #33

Closed
wants to merge 2 commits into
base: staging
from

Conversation

3 participants
@sidnei
Contributor

sidnei commented Aug 19, 2013

Per issue #32, add support for specifying a thin pool at lxc-create time.

Still needs some work to expose the thin pool defaults through lxc config.

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Aug 30, 2013

Member

Hi,

The change looks reasonable but the diff is a bit messy.

Would you mind updating your branch, squashing to a single commit, adding Signed-off-by and dropping any unneeded delta (whitespaces/tabs are poluting the diff currently).

Thanks

Member

stgraber commented Aug 30, 2013

Hi,

The change looks reasonable but the diff is a bit messy.

Would you mind updating your branch, squashing to a single commit, adding Signed-off-by and dropping any unneeded delta (whitespaces/tabs are poluting the diff currently).

Thanks

@ghost ghost assigned hallyn Sep 4, 2013

@stgraber stgraber closed this Sep 22, 2013

hallyn added a commit to hallyn/lxc that referenced this pull request Nov 12, 2014

Merge pull request #33 from stgraber/master
Add initial rest-api spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment