cgroups: Introduce lxc.cgroup.dir.monitor.pivot - fixes cgroup removal on termination #3563
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On termination lxc may fail to remove either
lxc.cgroup.dir
orlxc.cgroup.dir.monitor
,because the monitor process may still be a member of either of these cgroups.
The pivot cgroup should not be a member (subpath) of any other container cgroup (dir)
because only empty cgroups can be removed.
Although I've used the newly introduced option
lxc.cgroup.dir.monitor
as prefix this option should work finewith with either
lxc.cgroup.dir
orlxc.cgroup.dir.monitor
.I've discovered this when working on
crio-lxc
- I found the following warning in the log.The lxc config with this option will look like this (for
crio-lxc
):