make setproctitle()'s /proc/pid/stat parsing safe #4299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testsuite passed |
it turns out that our parsing of /proc/pid/stat was not safe in general (though probably safe for lxc, since our executable names do not contain spaces). Let's fix this by looking backwards through the file for ), and then continuing on from there. This was reported to me by Solar Designer, who pointed me to this thread: https://twitter.com/solardiz/status/1634204168545001473 Indeed, this is a lot of tap dancing to work around the kernel's 16 character executable limit. Perhaps I'll send a kernel patch to raise that limit next. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
tych0
force-pushed
the
make-setproctitle-safe
branch
from
2d29de2
to
f7f15b2
Compare
|
Testsuite passed |
fengjixuchui
added a commit
to fengjixuchui/lxc
that referenced
this pull request
Apr 11, 2023
Merge pull request lxc#4299 from tych0/make-setproctitle-safe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it turns out that our parsing of /proc/pid/stat was not safe in general (though probably safe for lxc, since our executable names do not contain spaces).
Let's fix this by looking backwards through the file for ), and then continuing on from there.
This was reported to me by Solar Designer, who pointed me to this thread: https://twitter.com/solardiz/status/1634204168545001473
Indeed, this is a lot of tap dancing to work around the kernel's 16 character executable limit. Perhaps I'll send a kernel patch to raise that limit next.