/lxc

lxc-start-ephemeral: Parse passwd directly #667

Merged
merged 1 commit into from Sep 30, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cjwatson @stgraber
@cjwatson
Contributor

cjwatson commented Sep 30, 2015

On Ubuntu 15.04, lxc-start-ephemeral's call to pwd.getpwnam always
fails. While I haven't been able to prove it or track down an exact
cause, I strongly suspect that glibc does not guarantee that you can
call NSS functions after a context switch without re-execing. (Running
"id root" in a subprocess from the same point works fine.)

It's safer to use getent to extract the relevant line from the passwd
file and parse it directly.

Signed-off-by: Colin Watson cjwatson@ubuntu.com
@cjwatson
lxc-start-ephemeral: Parse passwd directly 
On Ubuntu 15.04, lxc-start-ephemeral's call to pwd.getpwnam always
fails.  While I haven't been able to prove it or track down an exact
cause, I strongly suspect that glibc does not guarantee that you can
call NSS functions after a context switch without re-execing.  (Running
"id root" in a subprocess from the same point works fine.)

It's safer to use getent to extract the relevant line from the passwd
file and parse it directly.

Signed-off-by: Colin Watson <cjwatson@ubuntu.com>
c6be89f

stgraber added a commit that referenced this pull request Sep 30, 2015

@stgraber
Merge pull request #667 from cjwatson/ephemeral-parse-passwd 
lxc-start-ephemeral: Parse passwd directly
e209cdd

@stgraber stgraber merged commit e209cdd into lxc:master Sep 30, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

z-image pushed a commit to z-image/lxc that referenced this pull request Oct 16, 2016

@stgraber
Merge pull request #667 from cjwatson/ephemeral-parse-passwd 
lxc-start-ephemeral: Parse passwd directly
7d50a39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment