Add support for using thin provisioned lvm volumes when creating a container. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when creating the container. When cloning a container backed by a thin pool, the clone will default to the same thin pool.
| char *cmd, output[12]; | ||
| const char *lvscmd = "lvs --unbuffered --noheadings -o lv_attr %s 2>/dev/null"; | ||
|
|
||
| len = strlen(lvscmd) + strlen(path) - 1; |
There was a problem hiding this comment.
Why -1 here? The strlen() returns length not including final \0. So I think you actually want a +1 for a final \0. Am I thinking wrong?
There was a problem hiding this comment.
'%s' is 2 chars long and gets replaced by path, so if I'm doing the math right then -1 is correct.
added 2 commits
October 18, 2013 16:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Per issue #32, add a --thinpool argument to lxc-create, to use thin pool backed lvm when creating
the container. When cloning a container backed by a thin pool, the clone will default
to the same thin pool.