New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pam: cgroup v2 fixes #221

Merged
merged 3 commits into from Nov 11, 2017

Conversation

2 participants
@brauner
Member

brauner commented Nov 2, 2017

In order to enable proper unprivileged cgroup delegation on newer kernels we not
just need delegate the "cgroup.procs" file to the user but also to
"cgroup.threads". But don't report an error in case it doesn't exist.
Also delegate "cgroup.subtree_control" to enable users to hand over controllers
to descendant cgroups.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

@hallyn

Thanks, looks good. Please ping me on irc when ready to merge.

Show outdated Hide outdated bindings.c Outdated
Show outdated Hide outdated bindings.c Outdated

brauner added some commits Nov 2, 2017

bindings: record mount namespace
This will allows us to attach to the mount namespace in case we need to debug or
perform some action on update.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
bindings: remove unused function
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
pam: adapt to changed cgroup v2 layout
In order to enable proper unprivileged cgroup delegation on newer kernels we not
just need delegate the "cgroup.procs" file to the user but also to
"cgroup.threads". But don't report an error in case it doesn't exist.
Also delegate "cgroup.subtree_control" to enable users to hand over controllers
to descendant cgroups.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Nov 8, 2017

Member

@hallyn, should be good to got if you're fine with the changes.

Member

brauner commented Nov 8, 2017

@hallyn, should be good to got if you're fine with the changes.

@hallyn hallyn merged commit 8ccf565 into lxc:master Nov 11, 2017

3 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment