Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxcfs: fix shared library reload #364

Merged
merged 2 commits into from Mar 13, 2020
Merged

lxcfs: fix shared library reload #364

merged 2 commits into from Mar 13, 2020

Conversation

@brauner
Copy link
Member

brauner commented Mar 13, 2020

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

brauner added 2 commits Mar 13, 2020
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Recenly I've made failures to run the constructor or destructor fatal.
Mostly, because we can't guarantee correct functionality if they fail.
In fact we can't do anything useful at all (Maybe I can come up with
something more useful soon.)
In any case, this surfaced a bug where on systems that replace/delete
the current workding directory of lxcfs will cause the constructor to
crash on reload because the path that getcwd() returns does not exist
anymore. Fix this by always escaping to root after the construtor has
run but also make it optional in case someone is messing with chroot()s
or other things.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
@stgraber stgraber merged commit 987c416 into lxc:master Mar 13, 2020
3 checks passed
3 checks passed
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.