Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
WIP: Change ConnectInfo to take a RemoteConfig. #1709
Conversation
lxc-jenkins
commented
Mar 7, 2016
|
This pull request didn't trigger Jenkins as its author isn't in the whitelist. An organization member must perform one of the following:
Those commands are simple Github comments of the format: "jenkins: COMMAND" |
jameinel
referenced this pull request
in juju/juju
Mar 7, 2016
Merged
update to LXD master tip #4639
|
+1 on this, I have a PR that changes the way juju imports images, so I'll try and update it to use this (and whatever else we need) as well. I talked with @jameinel about it, so we're on the same page (although I need to find some time to update my juju pr :) |
|
jenkins: test this please |
|
Please run "go fmt ./..." |
stgraber
added
the
Blocked
label
Mar 8, 2016
|
jenkins: test this please |
|
Looks good, keeping it blocked until we finish doing some jenkins optimizations though. |
jameinel commentedMar 7, 2016
We need the other attributes of RemoteConfig in order to connect
to the simplestreams and other 'static' hosts.
Signed-off-by: John Arbash Meinel john@arbash-meinel.com
I'm not 100% sure this is enough for us, I want to update the Juju client to match, so that Juju can use the known remotes to copy images for LXD provider instead of "lxd-images import". But I wanted to check that this is an ok step in that direction.