WIP: Change ConnectInfo to take a RemoteConfig. #1709

Merged
merged 2 commits into from Mar 8, 2016

Conversation

Projects
None yet
4 participants
Contributor

jameinel commented Mar 7, 2016

We need the other attributes of RemoteConfig in order to connect
to the simplestreams and other 'static' hosts.

Signed-off-by: John Arbash Meinel john@arbash-meinel.com

I'm not 100% sure this is enough for us, I want to update the Juju client to match, so that Juju can use the known remotes to copy images for LXD provider instead of "lxd-images import". But I wanted to check that this is an ok step in that direction.

Change ConnectInfo to take a RemoteConfig.
We need the other attributes of RemoteConfig in order to connect
to the simplestreams and other 'static' hosts.

Signed-off-by: John Arbash Meinel <john@arbash-meinel.com>

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@jameinel jameinel referenced this pull request in juju/juju Mar 7, 2016

Merged

update to LXD master tip #4639

Member

tych0 commented Mar 7, 2016

+1 on this, I have a PR that changes the way juju imports images, so I'll try and update it to use this (and whatever else we need) as well. I talked with @jameinel about it, so we're on the same page (although I need to find some time to update my juju pr :)

Owner

stgraber commented Mar 7, 2016

jenkins: test this please

Owner

stgraber commented Mar 8, 2016

Please run "go fmt ./..."

@stgraber stgraber added the Blocked label Mar 8, 2016

go fmt
Signed-off-by: John Arbash Meinel <john@arbash-meinel.com>
Owner

stgraber commented Mar 8, 2016

jenkins: test this please

Owner

stgraber commented Mar 8, 2016

Looks good, keeping it blocked until we finish doing some jenkins optimizations though.

stgraber added a commit that referenced this pull request Mar 8, 2016

Merge pull request #1709 from jameinel/lxd-static-remotes
WIP: Change ConnectInfo to take a RemoteConfig.

@stgraber stgraber merged commit cfa2363 into lxc:master Mar 8, 2016

4 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment