Enable stacking for privileged containers #3155

Merged
merged 1 commit into from Apr 5, 2017

Conversation

Projects
None yet
3 participants
Owner

stgraber commented Apr 5, 2017

Signed-off-by: Stéphane Graber stgraber@ubuntu.com

Enable stacking for privileged containers
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

tyhicks commented Apr 5, 2017

This looks correct to me. I'll update this PR once I've discussed the safety of doing policy loads inside of a privileged container inside of an AppArmor policy namespace with John. Thanks!

Member

brauner commented Apr 5, 2017

I'll hold off on merging this until you ping me, @stgraber.

Owner

stgraber commented Apr 5, 2017

Based on IRC discussion, this is fine to merge as far as the apparmor team is concerned.

tyhicks commented Apr 5, 2017

After speaking with John Johansen about this, we think it is safe to stick a confined privileged container inside of an apparmor namespace, allow the container to inherit CAP_MAC_ADMIN, and grant the container access to the securityfs mounted inside of the container.

Thanks for putting this PR together. I look forward to using this feature.

Member

brauner commented Apr 5, 2017

Cool guys. This sounds super-exciting!

@brauner brauner merged commit f0f838c into lxc:master Apr 5, 2017

5 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment