New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad schema update #3903

Merged
merged 1 commit into from Oct 5, 2017

Conversation

3 participants
@stgraber
Member

stgraber commented Oct 5, 2017

No description provided.

@@ -164,6 +165,19 @@ func ensureUpdatesAreApplied(tx *sql.Tx, updates []Update, hook Hook) error {
return fmt.Errorf("failed to fetch update versions: %v", err)
}
// Fix bad upgrade code between 30 and 32

This comment has been minimized.

@freeekanayaka

freeekanayaka Oct 5, 2017

Member

FWIW, in this kind of situations I find it useful for future readers (including ourselves) to spend a bit more words for providing context, e.g. mention that we got 3 cases of this and that update 31 is now effectively a no-op. Alternatively filing a GH issue with this info and referencing the number in the comment would be even better. YMMV :)

@freeekanayaka

freeekanayaka Oct 5, 2017

Member

FWIW, in this kind of situations I find it useful for future readers (including ourselves) to spend a bit more words for providing context, e.g. mention that we got 3 cases of this and that update 31 is now effectively a no-op. Alternatively filing a GH issue with this info and referencing the number in the comment would be even better. YMMV :)

Fix bad DB schema update between schema 30 and 31
Closes #3878
Closes #3890

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Oct 5, 2017

Member

jenkins: test this please

Member

stgraber commented Oct 5, 2017

jenkins: test this please

@brauner brauner merged commit f8f84dd into lxc:master Oct 5, 2017

3 of 5 checks passed

Testsuite Testsuite failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment