New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfs: try pool import #3987

Merged
merged 1 commit into from Nov 7, 2017

Conversation

2 participants
@brauner
Member

brauner commented Oct 30, 2017

Closes #3976.

Signed-off-by: Christian Brauner christian.brauner@ubuntu.com

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Oct 30, 2017

Member

@brauner is poolName the actual zpool name or the dataset?

We need to do "zpool import tank" not "zpool import tank/lxd", so if it's the dataset, we should split on / and take [0].

Member

stgraber commented Oct 30, 2017

@brauner is poolName the actual zpool name or the dataset?

We need to do "zpool import tank" not "zpool import tank/lxd", so if it's the dataset, we should split on / and take [0].

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber
Member

stgraber commented Nov 4, 2017

@brauner ping?

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Nov 4, 2017

Member

Yeah, will take a look once I get some free cycles a the conference.

Member

brauner commented Nov 4, 2017

Yeah, will take a look once I get some free cycles a the conference.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Nov 4, 2017

Member

@stgraber, updated.

Member

brauner commented Nov 4, 2017

@stgraber, updated.

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Nov 5, 2017

Member

we'll want to re-try this after my branch is merged, should get us a cleaner test run.

Member

stgraber commented Nov 5, 2017

we'll want to re-try this after my branch is merged, should get us a cleaner test run.

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Nov 5, 2017

Member

jenkins: test this please

Member

stgraber commented Nov 5, 2017

jenkins: test this please

Show outdated Hide outdated lxd/storage_zfs.go Outdated
zfs: try pool import
Closes #3976.

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>

@stgraber stgraber merged commit 4a772fa into lxc:master Nov 7, 2017

4 of 5 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment