New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "lxc operation" #4007

Merged
merged 4 commits into from Nov 8, 2017

Conversation

2 participants
@stgraber
Member

stgraber commented Nov 7, 2017

No description provided.

stgraber added some commits Nov 7, 2017

lxc/network: Fix error message
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
client: Add GetOperationUUIDs and GetOperations
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
lxc/operation: Add new command
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
i18n: Update translation templates
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Nov 7, 2017

Member

Some reasons for this would be good. :)

Member

brauner commented Nov 7, 2017

Some reasons for this would be good. :)

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Nov 7, 2017

Member

It's useful for developers and users to see what's going on in the background and to have a chance to cancel things that are stuck.

We've always had this in our API, we just never bothered to expose it.

Member

stgraber commented Nov 7, 2017

It's useful for developers and users to see what's going on in the background and to have a chance to cancel things that are stuck.

We've always had this in our API, we just never bothered to expose it.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Nov 8, 2017

Member

I guess an API extension is not really needed since this has always been there.

Member

brauner commented Nov 8, 2017

I guess an API extension is not really needed since this has always been there.

@brauner brauner merged commit 81ec5b0 into lxc:master Nov 8, 2017

4 of 5 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Nov 8, 2017

Member

Correct, nothing changed at the API level, this branch even works if run against a LXD 2.0.0 server.

Member

stgraber commented Nov 8, 2017

Correct, nothing changed at the API level, this branch even works if run against a LXD 2.0.0 server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment