New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor our own copy of the old log15 #4019

Merged
merged 3 commits into from Nov 13, 2017

Conversation

2 participants
@stgraber
Member

stgraber commented Nov 13, 2017

Upstream log15 broke the v2 API seemingly by accident but has then not done anything to fix it despite multiple other affected downstreams reaching out. A side effect of that API break is that it's now using a number of new external dependencies, one of which has now regressed Go 1.6 support.

As we're not yet ready to require something more recent than Go 1.6 and log15 is a pretty small piece of code, we'll just ship our own copy of it until we consider switching to something else.

stgraber added some commits Nov 13, 2017

Vendor a copy of log15 in shared/log15
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Switch to the built-in log15
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Revert "Temporary workaround for log15 API breakage"
This reverts commit 30c8594.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>

@brauner brauner merged commit 66ebacc into lxc:master Nov 13, 2017

4 of 5 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment