New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /1.0/events to the /dev/lxd API (and some cleanup and fixes) #4117

Merged
merged 3 commits into from Dec 22, 2017

Conversation

2 participants
@stgraber
Member

stgraber commented Dec 21, 2017

No description provided.

stgraber added some commits Dec 21, 2017

lxd/containers: Fix tc egress rules
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
lxd/events: Cleanup event listener setup
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Dec 21, 2017

Member

I'm still working on adding a couple of tests for it.

Member

stgraber commented Dec 21, 2017

I'm still working on adding a couple of tests for it.

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 21, 2017

Member
Member

brauner commented Dec 21, 2017

Add /1.0/events to the /dev/lxd/sock API
Closes #3996

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Dec 21, 2017

Member

Now includes tests, documentation and API extension.

If Jenkins is happy, this should be ready to merge.

Member

stgraber commented Dec 21, 2017

Now includes tests, documentation and API extension.

If Jenkins is happy, this should be ready to merge.

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber
Member

stgraber commented Dec 22, 2017

@brauner ready

@brauner brauner merged commit e0b0f09 into lxc:master Dec 22, 2017

5 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment