New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“your first time using LXD” is confusing #4124

Merged
merged 2 commits into from Jan 4, 2018

Conversation

4 participants
@m4sk1n
Contributor

m4sk1n commented Dec 29, 2017

No description provided.

@lxc-jenkins

This comment has been minimized.

Show comment
Hide comment
@lxc-jenkins

lxc-jenkins Dec 29, 2017

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

lxc-jenkins commented Dec 29, 2017

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Dec 29, 2017

Member

jenkins: test this please

Member

brauner commented Dec 29, 2017

jenkins: test this please

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Dec 30, 2017

Member

This needs a "make i18n" and subsequent commit to update the translation templates. I can do it and then merge this.

Member

stgraber commented Dec 30, 2017

This needs a "make i18n" and subsequent commit to update the translation templates. I can do it and then merge this.

@m4sk1n

This comment has been minimized.

Show comment
Hide comment
@m4sk1n

m4sk1n Jan 2, 2018

Contributor

@stgraber can you do this, please?

Contributor

m4sk1n commented Jan 2, 2018

@stgraber can you do this, please?

m4sk1n and others added some commits Dec 29, 2017

change “your first time using LXD” to something less confusing
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
i18n: Update translation template
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Jan 4, 2018

Member

jenkins: test this please

Member

stgraber commented Jan 4, 2018

jenkins: test this please

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Jan 4, 2018

Member

Branch updated, just waiting for Jenkins to confirm it's happy.

Member

stgraber commented Jan 4, 2018

Branch updated, just waiting for Jenkins to confirm it's happy.

@stgraber stgraber merged commit 501a4e2 into lxc:master Jan 4, 2018

4 of 5 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@m4sk1n m4sk1n deleted the m4sk1n:patch-1 branch Jan 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment