New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes #4133

Merged
merged 7 commits into from Jan 4, 2018

Conversation

2 participants
@stgraber
Member

stgraber commented Jan 2, 2018

Fixed a number of issues that were reported over the Christmas break on my flight back home.

stgraber added some commits Jan 2, 2018

storage/btrfs: Fix handling of UUID-based mounts
Closes #4121

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
doc: Add /images/<fingerprint>/secret to API list
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
doc: List /1.0/storage-pools API endpoints
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
lxd/containers: No slahses in snapshot names
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
i18n: Update translation template
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
lxd/storage: Don't allow slashes in pool or volume names
Closes: #4127

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
lxd/init: Strip leading and trailing spaces
Closes: #4125

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 3, 2018

Member

jenkins: test this please

Member

brauner commented Jan 3, 2018

jenkins: test this please

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 3, 2018

Member

@stgraber, I haven't forgotten the branch but I can't really merge since Jenkins doesn't seem to want to test it...

Member

brauner commented Jan 3, 2018

@stgraber, I haven't forgotten the branch but I can't really merge since Jenkins doesn't seem to want to test it...

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Jan 3, 2018

Member

jenkins: test this please

Member

stgraber commented Jan 3, 2018

jenkins: test this please

@brauner

This comment has been minimized.

Show comment
Hide comment
@brauner

brauner Jan 3, 2018

Member

Looks like lvm - surprise, surprise - is unhappy:

EROR[01-03|17:26:25] Failed to create new "btrfs" UUID for container "uuid2" on storage pool "lxdtest-4N9-pool-btrfs": /dev/lxdtest-4N9-pool-btrfs/containers_uuid2 is mounted
 


error: Failed to run: btrfstune -f -u /dev/lxdtest-4N9-pool-btrfs/containers_uuid2: /dev/lxdtest-4N9-pool-btrfs/containers_uuid2 is mounted
Member

brauner commented Jan 3, 2018

Looks like lvm - surprise, surprise - is unhappy:

EROR[01-03|17:26:25] Failed to create new "btrfs" UUID for container "uuid2" on storage pool "lxdtest-4N9-pool-btrfs": /dev/lxdtest-4N9-pool-btrfs/containers_uuid2 is mounted
 


error: Failed to run: btrfstune -f -u /dev/lxdtest-4N9-pool-btrfs/containers_uuid2: /dev/lxdtest-4N9-pool-btrfs/containers_uuid2 is mounted
@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Jan 3, 2018

Member

ain't that fun... I'll take a look at what LVM's doing...

Member

stgraber commented Jan 3, 2018

ain't that fun... I'll take a look at what LVM's doing...

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Jan 3, 2018

Member

jenkins: test this please

Member

stgraber commented Jan 3, 2018

jenkins: test this please

@stgraber

This comment has been minimized.

Show comment
Hide comment
@stgraber

stgraber Jan 4, 2018

Member

@brauner so turns out Jenkins was just drunk, all green now.

Member

stgraber commented Jan 4, 2018

@brauner so turns out Jenkins was just drunk, all green now.

@brauner brauner merged commit 4022a29 into lxc:master Jan 4, 2018

5 checks passed

Branch target Branch target is correct
Details
Signed-off-by All commits signed-off
Details
Testsuite Testsuite passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment