Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Infiniband #6035

Merged
merged 23 commits into from Aug 7, 2019

Conversation

@tomponline
Copy link
Member

commented Aug 1, 2019

Migration of infiniband device into the new devices interface.

  • Infiniband Physical
  • Infiniband SR-IOV
  • Lantea testing & scripted testing

Includes #6043

Part of #5819

@tomponline tomponline force-pushed the tomponline:tp-device-infiniband branch 11 times, most recently from 3230f98 to 52d711e Aug 2, 2019

device/nic: Updates comments to remove "container" references
Also clarifies comments on Start() and Stop() functions.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@tomponline tomponline force-pushed the tomponline:tp-device-infiniband branch 5 times, most recently from c646c01 to f2f9b4b Aug 6, 2019

@tomponline tomponline marked this pull request as ready for review Aug 6, 2019

@tomponline

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

@stgraber this is ready for review now.

lxd/container_lxc.go Outdated Show resolved Hide resolved
lxd/container_lxc.go Outdated Show resolved Hide resolved
@stgraber

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

Looking good, just a few nits/comments.

@tomponline tomponline force-pushed the tomponline:tp-device-infiniband branch from f2f9b4b to 9c5d213 Aug 7, 2019

device/infiniband/physical: Adds infiniband physical device implement…
…ation

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@tomponline tomponline force-pushed the tomponline:tp-device-infiniband branch 4 times, most recently from 13b9d3d to 9362b8f Aug 7, 2019

lxd/container_lxc.go Outdated Show resolved Hide resolved

tomponline added some commits Aug 1, 2019

device/utils/disk: Adds disk management utils file
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/utils/infiniband: Adds infiniband utils file
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/util/unix: Adds unix device utils file
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
container: Updates references to deviceGetAttributes to device package
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
util: Removes BlockFsDetect as moved into device package
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device: Moves device related functions into device package
And updates references.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
container/lxc: Updates infiniband to use device package
Removes any functions that have been moved to device package.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/runconfig: Adds CGroups slice to RunConfig
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/utils/instance: Adds instanceGetReservedDevices function
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/infiniband: Adds infiniband device loader
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
container: Removes migrated infiniband validation
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
devices/validate: Updates validation to understand infiniband has nic…
…type

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device: Links up infiniband device
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/runconfig: Adds MountEntryItem struct definition for mounts
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/nic/sriov: Switches to use shared instanceGetReservedDevices
Also removes duplicate parent device check.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/infiniband/sriov: Adds infiniband sriov device implementation
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
container/lxc/infiniband: Removes old file
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
device/nic: Renames runConfig to runConf for consistency
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
test: Adds basic infiniband tests
Requires setting the LXD_IFB_PHYSICAL_PARENT and LXD_IFB_SRIOV_PARENT env vars for physical and sriov tests respectively.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
test: Updates NIC SR-IOV test to check for device reservation
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@tomponline tomponline force-pushed the tomponline:tp-device-infiniband branch from 9362b8f to 83494eb Aug 7, 2019

device: Removes single line if assignments
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@stgraber stgraber merged commit 7eea640 into lxc:master Aug 7, 2019

4 of 5 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tomponline tomponline deleted the tomponline:tp-device-infiniband branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.