Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device/proxy: Implements default listen file mode of 0644 #6047

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@tomponline
Copy link
Member

commented Aug 7, 2019

The documentation states that the default listen file mode is 0755 if not supplied.

However the mode argument was currently being passed to forkproxy as empty string if not supplied.

There was also no mention of 755 or umask in forkproxy itself, leading me to think the default as documented was not implemented.

After discussions with stgraber, we agreed a sensible default of 0644.

Signed-off-by: Thomas Parrott thomas.parrott@canonical.com

lxd/device/proxy.go Outdated Show resolved Hide resolved

tomponline added some commits Aug 7, 2019

device/proxy: Implements default listen file mode of 0644
The documentation states that the default listen file mode is 0755 if not supplied.

However the mode argument was currently being passed to forkproxy as empty string if not supplied.

There was also no mention of 755 or umask in forkproxy itself, leading me to think the default as documented was not implemented.

After discussions with stgraber, we agreed a sensible default of 0644.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
doc: Updates proxy default mode value to 0644
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@tomponline tomponline force-pushed the tomponline:tp-device-proxy-defaults branch from aa1013b to 1f57b55 Aug 8, 2019

@tomponline tomponline changed the title device/proxy: Implements default listen file mode of 0755 device/proxy: Implements default listen file mode of 0644 Aug 8, 2019

@stgraber stgraber merged commit 6a4cedb into lxc:master Aug 8, 2019

4 of 5 checks passed

Testsuite Test started
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tomponline tomponline deleted the tomponline:tp-device-proxy-defaults branch Aug 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.