Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

device/nic/sriov: Fixes mac_filtering when no hwaddr specified #6055

Merged
merged 1 commit into from Aug 9, 2019

Conversation

@tomponline
Copy link
Member

commented Aug 9, 2019

When testing on mellanox cards, the mac_filtering feature wasn't working when no hwaddr address was specified.

This was because LXD is supposed to set the VF interface's MAC on the parent's VF setting first before enabling spoof checking. However it was using the wrong volatile key.

Signed-off-by: Thomas Parrott thomas.parrott@canonical.com

device/nic/sriov: Fixes mac_filtering when no hwaddr specified
When testing on mellanox cards, the mac_filtering feature wasn't working when no hwaddr address was specified.

This was because LXD is supposed to set the VF interface's MAC on the parent's VF setting first before enabling spoof checking. However it was using the wrong volatile key.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@stgraber stgraber merged commit 03d37e4 into lxc:master Aug 9, 2019

4 of 5 checks passed

Testsuite Testsuite failed
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tomponline tomponline deleted the tomponline:tp-device-nic-sriov branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.