Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridged device MTU inheritance #6078

Merged
merged 5 commits into from Aug 14, 2019

Conversation

@tomponline
Copy link
Member

commented Aug 14, 2019

It has come to my attention that there is a feature in LXD bridged NIC devices that will inherit the MTU of the parent device if not overriden using the mtu device property.

However it has stopped working in LXD 3.16.

This issue existed in LXD 3.15 (and possibly earlier), but only during hot-plug, as LXD used liblxc's MTU inheritance feature for boot time setup.

However in LXD 3.16 the boot-time and hot-plug device setup code was unified and this bug is now present also during boot-time setup.

tomponline added some commits Aug 14, 2019

device/device/utils/network: Add support for MTU inheriting from pare…
…nt on bridged devices

If custom mtu setting is not supplied, and parent is supplied, then MTU is inherited from parent device.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
test: Adds test for bridged MTU parent inheritance
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
test: Adds test for macvlan MTU parent inheritance
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
doc: Updates NIC MTU descriptions
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
test: Adds test for ipvlan MTU parent inheritance
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>

@tomponline tomponline force-pushed the tomponline:tp-device-nic-mtu branch from 6dfd7ef to 546b28f Aug 14, 2019

@lxc-jenkins

This comment has been minimized.

Copy link

commented Aug 14, 2019

Testsuite passed

1 similar comment
@lxc-jenkins

This comment has been minimized.

Copy link

commented Aug 14, 2019

Testsuite passed

@stgraber stgraber merged commit ea7c5b8 into lxc:master Aug 14, 2019

5 checks passed

Branch target Branch target is correct
Details
DCO All commits signed-off
Details
Testsuite Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@tomponline tomponline deleted the tomponline:tp-device-nic-mtu branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.