Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
api/project: Fixes issue handling project names with URI encodable characters #6081
It was possible to do:
But one could not then do:
As the project name was encoded on the URL as "test+project", but was not decoded when being passed to the database query.
Signed-off-by: Thomas Parrott email@example.com
@tomponline same appear true for at least
Since this realistically couldn't have really worked for anyone, I'd say, look at everywhere we allow creating things with spaces today and then add checks to prevent it.
We should already have a similar check for slashes in most spots (only exception I can think of would be image aliases).