Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Device Types re-organise #6135
Since creating the
This has caused type conversion issues and came to a head during the development of the
This PR changes the following:
Part of #5819
4 times, most recently
Aug 30, 2019
So this feels wrong to me. The
Putting the entire Device struct and switching all
We should certainly use
@stgraber I've re-worked this PR this morning to move the device config types back to their original
This branch looks pretty confusing to me still.
I'm also not sure why
Can you clean things up a bit so that commits make individual sense and try to limit import renames at least for now so it's easier to review this?
@stgraber I've redone the branch again from scratch to limit the changes introduced.
I've strictly avoided importing
In some cases I've removed the dependency on