Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxc/init: Add parse of options from stdin #6138

Merged
merged 3 commits into from Sep 3, 2019

Conversation

@geaaru
Copy link
Contributor

commented Aug 31, 2019

It's now possible to parse configuration options from stdin in both lxc init and lxc launch commands.

Example:

$# $ cat /tmp/config.yml 
config:
  raw.lxc: |
    lxc.net.0.ipv4.address = 10.10.10.1/24
ephemeral: True
profiles:
- sdpool
- net-lxdbr0

$# lxc launch 64362190ee7c c1 < /tmp/config.yml
@lxc-jenkins

This comment has been minimized.

Copy link

commented Aug 31, 2019

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

@geaaru

This comment has been minimized.

Copy link
Contributor Author

commented Aug 31, 2019

The idea is command-line options has priority so, I load options from file and then you could update a specific device, storage or profiles, network from command-line instruction.

@stgraber

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@geaaru this feature addition should be describe in the help message for both lxc init and lxc launch.

@stgraber stgraber added the Incomplete label Sep 3, 2019

lxc/init|launch: Add parse of options from stdin
Signed-off-by: Daniele Rondina <geaaru@sabayonlinux.org>

@geaaru geaaru force-pushed the geaaru:lxc-init-from-stdin branch from a254c12 to 06a8f5c Sep 3, 2019

stgraber added 2 commits Sep 3, 2019
lxc/{init,launch}: Tweak example formatting
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
i18n: Update translation templates
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@stgraber

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

Just did one small formatting tweak and updated the translation templates.

@stgraber

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

jenkins: test this please

@stgraber stgraber merged commit e158382 into lxc:master Sep 3, 2019

4 of 5 checks passed

Testsuite Test started
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@geaaru geaaru deleted the geaaru:lxc-init-from-stdin branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.