Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage package #6285

Merged
merged 38 commits into from Oct 29, 2019

Conversation

@tomponline
Copy link
Member

tomponline commented Oct 7, 2019

Based on #6274

Includes #6317
Includes #6360

@tomponline

This comment has been minimized.

Copy link
Member Author

tomponline commented Oct 7, 2019

@stgraber as discussed, this is my PR of your storage branch where I will work.

@tomponline tomponline force-pushed the tomponline:tp-storage branch 8 times, most recently from b4909c8 to 35fa14c Oct 9, 2019
@tomponline tomponline requested a review from stgraber Oct 9, 2019
@tomponline

This comment has been minimized.

Copy link
Member Author

tomponline commented Oct 9, 2019

@stgraber I've added volume create and copy support for dir backend, please can you take a look and check the general direction. Tests should pass OK.

@tomponline tomponline requested a review from monstermunchkin Oct 9, 2019
@tomponline tomponline force-pushed the tomponline:tp-storage branch 2 times, most recently from 9675339 to e17bc11 Oct 9, 2019
@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Oct 9, 2019

Testsuite passed

lxd/storage/backend_lxd.go Outdated Show resolved Hide resolved
lxd/storage/backend_lxd.go Outdated Show resolved Hide resolved
lxd/storage/backend_lxd.go Outdated Show resolved Hide resolved
lxd/storage/backend_lxd.go Outdated Show resolved Hide resolved
lxd/storage/backend_lxd.go Outdated Show resolved Hide resolved
@tomponline tomponline force-pushed the tomponline:tp-storage branch 2 times, most recently from 026c73d to 990085d Oct 10, 2019
tomponline added 26 commits Oct 9, 2019
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…rage API

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
 - Volume struct type has functions that help with mounting/unmounting.
 - Allows a Volume from another storage pool on a different driver to be passed into a driver function on a different pool.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
- migrate
- move
- rename

Links move and rename actions to new storage pkg.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
 Adds storageDrivers import too.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…rage pkg

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…rage pkg

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…orage pkg

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…TypePost and storagePoolVolumesTypePost

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…tPath

Uses "path" suffix to better indicate what is returned. "point" seemed rather vague.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…d our types on mismatch

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-storage branch from 562d962 to 84653a7 Oct 29, 2019
@stgraber stgraber merged commit a712d39 into lxc:master Oct 29, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline tomponline deleted the tomponline:tp-storage branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.