Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support squashfs as compression algorithm #6356

Merged
merged 6 commits into from Nov 4, 2019

Conversation

@ulziibuyan
Copy link
Contributor

ulziibuyan commented Oct 28, 2019

Supposedly closes #6273

ulziibuyan added 5 commits Oct 26, 2019
Signed-off-by: Uzi Erdenebileg <lzijbuan@gmail.com>
Signed-off-by: Uzi Erdenebileg <lzijbuan@gmail.com>
Signed-off-by: Uzi Erdenebileg <lzijbuan@gmail.com>
Signed-off-by: Uzi Erdenebileg <lzijbuan@gmail.com>
Signed-off-by: Uzi Erdenebileg <lzijbuan@gmail.com>
@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Oct 28, 2019

This pull request didn't trigger Jenkins as its author isn't in the whitelist.

An organization member must perform one of the following:

  • To have this branch tested by Jenkins, use the "ok to test" command.
  • To have a one time test done, use the "test this please" command.

Those commands are simple Github comments of the format: "jenkins: COMMAND"

lxd/backup/backup.go Outdated Show resolved Hide resolved
lxd/container.go Outdated Show resolved Hide resolved
lxd/container.go Show resolved Hide resolved
lxd/images.go Outdated Show resolved Hide resolved
lxd/images.go Show resolved Hide resolved
Copy link
Member

stgraber left a comment

Looks very good, thank you!

Just a couple tiny issues/nits and we should be good to send this through Jenkins.

@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Oct 29, 2019

Signed-off-by: Uzi Erdenebileg <lzijbuan@gmail.com>
@ulziibuyan

This comment has been minimized.

Copy link
Contributor Author

ulziibuyan commented Nov 3, 2019

Made the changes as requested.

@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Nov 4, 2019

jenkins: test this please

@stgraber stgraber self-requested a review Nov 4, 2019
@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Nov 4, 2019

Thanks!

@stgraber stgraber merged commit 586ed15 into lxc:master Nov 4, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Test started
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Nov 4, 2019

Testsuite passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.