Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration using ReadWriteCloser #6360

Merged
merged 9 commits into from Oct 29, 2019

Conversation

@tomponline
Copy link
Member

tomponline commented Oct 28, 2019

This PR modifies the migration code and rsync package to use a ReadWriteCloser for remote connection rather than a web socket. The intention for this is to allow the re-use of migration code for copying local volumes between different storage pools.

@tomponline tomponline requested a review from stgraber Oct 28, 2019
@tomponline tomponline force-pushed the tomponline:tp-migration branch 5 times, most recently from 8407c2e to 4f2b062 Oct 28, 2019
@tomponline tomponline marked this pull request as ready for review Oct 29, 2019
@tomponline tomponline mentioned this pull request Oct 29, 2019
@tomponline tomponline force-pushed the tomponline:tp-migration branch 2 times, most recently from c1790aa to 4a3dd00 Oct 29, 2019
stgraber and others added 9 commits Oct 25, 2019
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Allows for cancellation if client disconnects.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-migration branch from 4a3dd00 to 4888373 Oct 29, 2019
@stgraber stgraber merged commit 4888373 into lxc:master Oct 29, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline tomponline deleted the tomponline:tp-migration branch Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.