Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Update Snapshot #6373

Merged
merged 3 commits into from Oct 31, 2019

Conversation

@tomponline
Copy link
Member

tomponline commented Oct 31, 2019

Moves the DB logic from the legacy storage functions directly into the API (which is similar to existing functions that do DB lookups and modifications for simple cases). This way the legacy storage function can be removed and it does fewer DB queries.

Includes #6371

@tomponline tomponline requested a review from stgraber Oct 31, 2019
@tomponline tomponline force-pushed the tomponline:tp-storage-update-snapshot branch from 8faca9d to 12b5a54 Oct 31, 2019
tomponline added 3 commits Oct 31, 2019
…with storagePoolVolumeSnapshotTypePut

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…DB logic

Moves DB logic from legacy storage functions into API directly (as just DB updates) as its just a description update.

This will then work with both old and new storage layers.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…date

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-storage-update-snapshot branch from 12b5a54 to 441d1ad Oct 31, 2019
@tomponline tomponline mentioned this pull request Oct 31, 2019
@stgraber stgraber merged commit 346fb92 into lxc:master Oct 31, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline tomponline deleted the tomponline:tp-storage-update-snapshot branch Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.