Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lxd/storage: Fix custom volume with underscores #6390

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@stgraber
Copy link
Member

stgraber commented Nov 4, 2019

The recently added project logic in the volume code incorrectly assumes
that underscores are only valid as separate between project names and
volume names.

This isn't true for custom volumes which may already have undercores in
their names despite us not having support for custom volumes in projects.

When we do implement custom volumes in projects, we will rename all
volumes to include the project prefix at which point we will be able to
always split those and extract the project. Until then, only do project
splitting on containers.

Signed-off-by: Stéphane Graber stgraber@ubuntu.com

The recently added project logic in the volume code incorrectly assumes
that underscores are only valid as separate between project names and
volume names.

This isn't true for custom volumes which may already have undercores in
their names despite us not having support for custom volumes in projects.

When we do implement custom volumes in projects, we will rename all
volumes to include the project prefix at which point we will be able to
always split those and extract the project. Until then, only do project
splitting on containers.

Signed-off-by: Stéphane Graber <stgraber@ubuntu.com>
@brauner brauner merged commit 6c4f775 into lxc:master Nov 4, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline

This comment has been minimized.

Copy link
Member

tomponline commented Nov 4, 2019

@stgraber thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.