Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage backup import cleanup #6513

Merged
merged 4 commits into from Nov 26, 2019
Merged

Conversation

@tomponline
Copy link
Member

tomponline commented Nov 26, 2019

This PR lays the groundwork needed to link backup restoration to new storage layer.

  • Renames containerCreateFromBackup to instanceCreateFromBackup.
  • Modifies instanceCreateFromBackup to return a revert function rather than the old storage pool (used to delete the unpacked backup files on error).
  • Restructures instanceCreateFromBackup to only use the storage pool in a single place (which will then be replaced with the new storage pkg where possible).
tomponline added 4 commits Nov 26, 2019
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…rn storage

- Lays the groundwork to support both old and new storage layers.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…urned from instanceCreateFromBackup

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline requested a review from stgraber Nov 26, 2019
@stgraber stgraber merged commit 3d75825 into lxc:master Nov 26, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline tomponline deleted the tomponline:tp-storage-backup-import branch Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.