Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'containers' to 'instances' in used_by fields for projects and profiles #6514

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@freeekanayaka
Copy link
Member

freeekanayaka commented Nov 26, 2019

First pass at #6491. I'm planning to change the user-visible bits in a separate branch.

@freeekanayaka freeekanayaka force-pushed the freeekanayaka:dont-hard-code-used-by-url branch from ea1af1d to 260121c Nov 26, 2019
@freeekanayaka freeekanayaka changed the title Dont hard code UsedBy urls in db views [RFC] Dont hard code UsedBy urls in db views Nov 26, 2019
@freeekanayaka

This comment has been minimized.

Copy link
Member Author

freeekanayaka commented Nov 26, 2019

I'm not sure anymore we want/need to do this, see the comment in the issue.

@freeekanayaka freeekanayaka force-pushed the freeekanayaka:dont-hard-code-used-by-url branch from 260121c to d0974d3 Nov 26, 2019
@freeekanayaka freeekanayaka changed the title [RFC] Dont hard code UsedBy urls in db views Change 'containers' to 'instances' in used_by fields for projects and profiles Nov 26, 2019
@freeekanayaka freeekanayaka force-pushed the freeekanayaka:dont-hard-code-used-by-url branch from d0974d3 to aded1f1 Nov 26, 2019
Signed-off-by: Free Ekanayaka <free.ekanayaka@canonical.com>
@freeekanayaka freeekanayaka force-pushed the freeekanayaka:dont-hard-code-used-by-url branch from aded1f1 to a3e844b Nov 26, 2019
@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Nov 26, 2019

@freeekanayaka looks like something is busted in UsedBy for networks?

Signed-off-by: Free Ekanayaka <free.ekanayaka@canonical.com>
@freeekanayaka

This comment has been minimized.

Copy link
Member Author

freeekanayaka commented Nov 26, 2019

@stgraber ah true, the used_by field for networks is not rendered using those db views (which are indeed unrelated), but still I had changed the networks integration tests to look for "/1.0/instances" instead of "/containers", regressing them. I assume we want "/1.0/instances" also for networks, so I fixed the code as well.

@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Nov 26, 2019

@freeekanayaka yep, perfect, thanks

@stgraber stgraber merged commit 4e395c7 into lxc:master Nov 26, 2019
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@freeekanayaka freeekanayaka deleted the freeekanayaka:dont-hard-code-used-by-url branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.