Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage backup import #6522

Merged
merged 12 commits into from Nov 28, 2019
Merged

Storage backup import #6522

merged 12 commits into from Nov 28, 2019

Conversation

@tomponline
Copy link
Member

tomponline commented Nov 28, 2019

Includes #6521

@stgraber

This comment has been minimized.

Copy link
Member

stgraber commented Nov 28, 2019

@tomponline

lxd/container.go:310:9: "neccessary" is a misspelling of "necessary"
lxd/storage/backend_lxd.go:333:9: "neccessary" is a misspelling of "necessary"

And you can use this as an opportunity to rebase :)

@tomponline tomponline force-pushed the tomponline:tp-storage-backup-import2 branch from 8c95a4a to 4079681 Nov 28, 2019
@tomponline

This comment has been minimized.

Copy link
Member Author

tomponline commented Nov 28, 2019

@stgraber indeed, I seem to have real trouble with the spelling of that word. Fixed and rebased.

@tomponline tomponline requested a review from stgraber Nov 28, 2019
@tomponline tomponline force-pushed the tomponline:tp-storage-backup-import2 branch from 4079681 to ff74049 Nov 28, 2019
tomponline added 12 commits Nov 27, 2019
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
- pool.CreateInstanceFromBackup() will do decompression for new storage layer.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Will use an io.ReadSeeker to access backup file source rather than opening file path.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ePool to take mount path

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Clarifies that image type is not the same as instance type.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…own function

Will be used in forthcoming backup restore function.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-storage-backup-import2 branch from ff74049 to ba0660f Nov 28, 2019
@stgraber stgraber merged commit 03806c5 into lxc:master Nov 28, 2019
2 of 5 checks passed
2 of 5 checks passed
Testsuite Test started
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
@tomponline tomponline deleted the tomponline:tp-storage-backup-import2 branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.