Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage migration sink cleanup #6528

Merged
merged 3 commits into from Nov 29, 2019
Merged

Conversation

@tomponline
Copy link
Member

tomponline commented Nov 29, 2019

Restructures migration sink Do() function to allow linking of new storage layer more cleanly.

tomponline added 2 commits Nov 29, 2019
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
- This is to accomodate the forthcoming link to the new storage layer.
- Renames the offer and response header variables to align with naming used in custom volume migration.
- Gathers together the legacy offer negotiation code so as to be easily segrated when new storage layer is linked.
- Passes rsyncFeatures from generated response header rather than offer header, to align with custom volume migration.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline requested a review from stgraber Nov 29, 2019
Golint suggestions too.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-storage-migration-create2 branch from f11d28b to 2209f72 Nov 29, 2019
@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Nov 29, 2019

Testsuite passed

1 similar comment
@lxc-jenkins

This comment has been minimized.

Copy link

lxc-jenkins commented Nov 29, 2019

Testsuite passed

@stgraber stgraber merged commit 9a6478d into lxc:master Nov 29, 2019
5 checks passed
5 checks passed
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
Testsuite Build finished.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline tomponline deleted the tomponline:tp-storage-migration-create2 branch Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.