Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage migration sink cleanup #6528

Merged
merged 3 commits into from Nov 29, 2019
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

lxd/migrate/storage/volumes: Comment restructure

Golint suggestions too.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
  • Loading branch information
tomponline committed Nov 29, 2019
commit 2209f72131c2ee3c88f51e869af8cf43598e85b1
@@ -427,12 +427,10 @@ func (c *migrationSink) DoStorage(state *state.State, poolName string, req *api.
restore := make(chan error)

go func(c *migrationSink) {
/* We do the fs receive in parallel so we don't have to reason
* about when to receive what. The sending side is smart enough
* to send the filesystem bits that it can before it seizes the
* container to start checkpointing, so the total transfer time
* will be minimized even if we're dumb here.
*/
// We do the fs receive in parallel so we don't have to reason about when to receive
// what. The sending side is smart enough to send the filesystem bits that it can
// before it seizes the container to start checkpointing, so the total transfer time
// will be minimized even if we're dumb here.
fsTransfer := make(chan error)

go func() {
@@ -498,12 +496,12 @@ func (c *migrationSink) DoStorage(state *state.State, poolName string, req *api.
if !*msg.Success {
disconnector()
return fmt.Errorf(*msg.Message)
} else {
// The source can only tell us it failed (e.g. if
// checkpointing failed). We have to tell the source
// whether or not the restore was successful.
logger.Debugf("Unknown message %v from source", msg)
}

// The source can only tell us it failed (e.g. if
// checkpointing failed). We have to tell the source
// whether or not the restore was successful.
logger.Debugf("Unknown message %v from source", msg)
}
}
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.