Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container: tar writer backup #7057

Merged
merged 19 commits into from Mar 19, 2020
Merged

Container: tar writer backup #7057

merged 19 commits into from Mar 19, 2020

Conversation

@tomponline
Copy link
Member

tomponline commented Mar 19, 2020

More efficient backup routine using tar writer rather than temporary directories and tar command.

  • Generic backup (mounts volume and adds files directly to tar file).
  • Optimised backup (creates temporary binary file of volume and adds to tar file).

Includes #7056

@tomponline

This comment has been minimized.

Copy link
Member Author

tomponline commented Mar 19, 2020

@stgraber tested generic vfs tarball created with tar writer compared to that created previously with tar:

mkdir backuptest
tar zxvf /home/user/c1-known-good.tar.gz
git init && git add -A .
git commit -a -mgood
rm backup/ -Rvf
tar zxvf /home/user/c1-new.tar.gz
git status
On branch master
nothing to commit, working tree clean
…emove

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-container-backup branch 2 times, most recently from 9ec5cd8 to 57451b9 Mar 19, 2020
tomponline added 16 commits Mar 19, 2020
We are going to be using tar writer instead.

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
… cmd

Also:
	Use of renamed functions
	Error message quoting
	Improves logging
	Uses revert package

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…meFromMigration

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…ar writer

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…Volume

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…upVolume

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…olume

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…olume

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-container-backup branch 2 times, most recently from 3933fb3 to 5fff10b Mar 19, 2020
@tomponline tomponline requested a review from stgraber Mar 19, 2020
@tomponline tomponline marked this pull request as ready for review Mar 19, 2020
tomponline added 2 commits Mar 19, 2020
…pVolume

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
…olume

Signed-off-by: Thomas Parrott <thomas.parrott@canonical.com>
@tomponline tomponline force-pushed the tomponline:tp-container-backup branch from 5fff10b to 1ad4c4a Mar 19, 2020
@tomponline tomponline self-assigned this Mar 19, 2020
@tomponline tomponline mentioned this pull request Mar 19, 2020
4 of 4 tasks complete
@stgraber stgraber merged commit dd70efe into lxc:master Mar 19, 2020
4 of 5 checks passed
4 of 5 checks passed
Testsuite Build finished.
Details
Branch target Branch target is correct
Details
DCO All commits signed-off
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@tomponline tomponline deleted the tomponline:tp-container-backup branch Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.