Use lxqt-sudo by default #204

Closed
pmattern opened this Issue Aug 4, 2015 · 7 comments

Comments

Projects
None yet
4 participants
Member

pmattern commented Aug 4, 2015

In order to open a new window as root (Tool - Open as root) PCManFM-Qt is looking for gksu as backend only by default.
This should be replaced with lxqt-sudo introduced recently in the long run.

Btw. shouldn't this be 'Tool_s_' in the menu bar?

[Edit: correct that backend can be chosen and hence gksu isn't the only one available but just the default]

q4a commented Aug 15, 2015

You can change it in settings: http://i.imgur.com/fRUQUlCh.png
This does not working for me: nothing happens. May be it's lxqt-sudo bug?
PS I still can run "lxqt-sudo pcmanfm-qt" from command line and get it working.

@pmattern pmattern changed the title from Use lxqt-sudo instead of gksu as su GUI to Use lxqt-sudo by default Aug 15, 2015

Member

pmattern commented Aug 15, 2015

You can change it in settings [...]

Of course. I had totally forgotten that setting when filing this issue and modified the text accordingly.

The apparent malfunction of lxqt-sudo is probably due to the fact that PCManFM-Qt isn't assuming sudo as backend but su and support of the latter is wip in lxqt-sudo.

(So basically this issue has to be postponed until the problems that came up in the said PR are fixed.)

Owner

agaida commented Aug 28, 2015

@pmattern - makeing lxqt-sudo default would introduce a dependeny (or at least a recommend) to lxqt-sudo, so pcmanfm-qt should look if lxqt-sudo is present and has a reliable fallback - no clue if this is a really clever move (mind using pcmanfm-qt outside of LXQt). But i would second this.

Member

pmattern commented Aug 29, 2015

@agaida
Are you sure regarding dependencies?
Grepping through the code and running ldd strongly suggest that it's not a dependency at all but just a configuration setting, see here.
So trading gksu with lxqt-sudo or what ever it may be renamed to wouldn't change dependencies at all, would it?

Owner

agaida commented Aug 30, 2015

not a build dependency or so - but i would consider a program broken if it blindly trust in the presence of another package - so this should be handled gracefully - in that case it isn't a dependency, just recommended.

Member

pmattern commented Aug 30, 2015

Don't know whether there's some kind of common approach to deal with "soft dependencies" like this. But isn't it rather downstream's / packager's job to craft their packages accordingly, something like optdepends on Arch Linux or Recommends / Suggests on Debian and derivatives?

Nevertheless I still think trading gksu with something different wouldn't change the situation regarding dependencies at all and that hence the latter is beyond this issue's scope.

Owner

PCMan commented Jan 22, 2016

Done. The default value is changed to lxqt-sudo now in pcmanfm-qt and the default config file shipped with lxqt-common.

@PCMan PCMan closed this Jan 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment