Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make html basis #20

Merged
merged 2 commits into from May 15, 2021
Merged

Make html basis #20

merged 2 commits into from May 15, 2021

Conversation

item4
Copy link
Contributor

@item4 item4 commented Dec 19, 2020

I try to make lxml.html module basis. But I am not good for internal of lxml. I will make draft PR. Please review that?

@item4
Copy link
Contributor Author

item4 commented Dec 19, 2020

p.s. I write this code based on https://lxml.de/apidoc/_modules/lxml/html.html

@item4
Copy link
Contributor Author

item4 commented Dec 26, 2020

any review?

@item4 item4 marked this pull request as ready for review February 16, 2021 07:35
@djbrown djbrown mentioned this pull request May 15, 2021
Copy link
Member

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, and sorry for the long delay.

lxml-stubs/html/__init__.pyi Outdated Show resolved Hide resolved
@scoder scoder merged commit 2782f1d into lxml:master May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants