New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting the base url for etree.Resolver.resolve_string #198

Merged
merged 1 commit into from Jul 18, 2016

Conversation

Projects
None yet
2 participants
@mvantellingen
Contributor

mvantellingen commented Jul 18, 2016

See https://github.com/GNOME/libxml2/blob/master/parserInternals.c#L1549
We seem to get away with only setting the _filename so that relative
url's are resolved based on the value.

Fixes https://bugs.launchpad.net/lxml/+bug/1568167

Fix setting the base url for etree.Resolver.resolve_string
See https://github.com/GNOME/libxml2/blob/master/parserInternals.c#L1549
We seem to get away with only setting the _filename so that relative
url's are resolved based on the value.

Fixes https://bugs.launchpad.net/lxml/+bug/1568167
@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Jul 18, 2016

Member

Thanks!

Member

scoder commented Jul 18, 2016

Thanks!

@scoder scoder merged commit 989a253 into lxml:master Jul 18, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Jul 18, 2016

Member

A test would be nice, BTW.

Member

scoder commented Jul 18, 2016

A test would be nice, BTW.

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Jul 18, 2016

Member

The file path might need encoding in some cases. I pushed a fix here: 5da090b

Member

scoder commented Jul 18, 2016

The file path might need encoding in some cases. I pushed a fix here: 5da090b

@mvantellingen

This comment has been minimized.

Show comment
Hide comment
@mvantellingen

mvantellingen Jul 25, 2016

Contributor

Thanks, i'll add writing a unittest for this on my todo list :-)

Contributor

mvantellingen commented Jul 25, 2016

Thanks, i'll add writing a unittest for this on my todo list :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment