New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to prevent default doctypes #203

Merged
merged 1 commit into from Aug 20, 2016

Conversation

Projects
None yet
2 participants
@dufferzafar
Contributor

dufferzafar commented Aug 19, 2016

This adds a new option to the HTMLParser which passes out corresponding flag to libxml.

There's another option HTML_PARSE_NOIMPLIED which is defined by libxml but we don't take it in as a parameter.


Reason why this was added:
mitmproxy/mitmproxy#845

Post on mailing list:
https://mailman-mail5.webfaction.com/pipermail/lxml/2016-August/007738.html

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Aug 20, 2016

Member

Thanks

Member

scoder commented Aug 20, 2016

Thanks

@scoder scoder merged commit 24b917e into lxml:master Aug 20, 2016

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Aug 20, 2016

Member

Note, BTW, that I'm free to remove this option or render it disfunctional at any time, given that I won't be breaking any tests while doing that. ;-)

Member

scoder commented Aug 20, 2016

Note, BTW, that I'm free to remove this option or render it disfunctional at any time, given that I won't be breaking any tests while doing that. ;-)

@dufferzafar

This comment has been minimized.

Show comment
Hide comment
@dufferzafar

dufferzafar Aug 20, 2016

Contributor

@scoder I'm new to cython etc. and wanted to get some preliminary feedback before I delved into tests. I didn't really expect that it'll be merged so easily :P

Do you want me to write some tests & create a new PR?

Contributor

dufferzafar commented Aug 20, 2016

@scoder I'm new to cython etc. and wanted to get some preliminary feedback before I delved into tests. I didn't really expect that it'll be merged so easily :P

Do you want me to write some tests & create a new PR?

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Aug 20, 2016

Member

Please do.

Member

scoder commented Aug 20, 2016

Please do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment