Fixing possible memory corruption in doc dictionary if node is moved between docs #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etree.insert function tries to handle the case when a node is moved between documents with the function moveNodeToDocument. So far the source_doc is taken from the destination node which is wrong. The moveNodeToDocument function will not fix the names in the document dictionaries because source and target doc are the same. The fix takes now the source_doc from the node element which should be inserted. This fixes issue https://bugs.launchpad.net/lxml/+bug/1773749
|
Interesting bug. Thanks! |
scoder
added a commit
that referenced
this pull request
Aug 3, 2018
|
Fix released in lxml 4.2.4. |
scoder
added a commit
that referenced
this pull request
Aug 3, 2018
|
Thanks for the fast merge and new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
etree.insert function tries to handle the case when a node is moved
between documents with the function moveNodeToDocument. So far the
source_doc is taken from the destination child node which is wrong.
The moveNodeToDocument function will not fix the names in the
document dictionaries because source and target doc are the same.
The fix takes now the source_doc from the node element which
should be inserted.
This fixes issue https://bugs.launchpad.net/lxml/+bug/1773749